Skip to content

Fix #484: Fixed misalignment issue under 'Wrapper' section #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rahulsnkr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix #484: Fixed misalignment issue under 'Wrapper' section #507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ide/static/css/zoo.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ body {
overflow-x: hidden;
}

#wrapper {
#content-wrapper {

@Ram81 Ram81 Dec 19, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rahulsnkr didn't get this, why would changing the id of the css class worked for you?

@rahulsnkr rahulsnkr Dec 19, 2018 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ram81

Fabrik/ide/static/js/pane.js

Lines 457 to 466 in 0bb88a5

<div id="wrapper" className="panel-collapse collapse" role="tabpanel">
<div className="panel-body">
<PaneElement setDraggingLayer={this.props.setDraggingLayer}
handleClick={this.props.handleClick}
id="TimeDistributed_Button">Time Distributed</PaneElement>
<PaneElement setDraggingLayer={this.props.setDraggingLayer}
handleClick={this.props.handleClick}
id="Bidirectional_Button">Bidirectional</PaneElement>
</div>
</div>

The 'Wrapper' section in the pane.js file also has the same id, so the padding was being applied to that too. So I changed the id of the div in modelZoo.js, and the corresponding property name in zoo.css from 'wrapper' to 'content-wrapper'

padding-left: 250px;
}

Expand Down
2 changes: 1 addition & 1 deletion ide/static/js/modelZoo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class ModelZoo extends React.Component {

return (
<div className="sidebar-content">
<div id="wrapper" className="toggle" ref="wrapper1">
<div id="content-wrapper" className="toggle" ref="wrapper1">
<div id="sidebar-wrapper">
<ul id="sidebar-nav" className="sidebar-nav">
<div className="filterbar-container">
Expand Down