Share Model URL fix - #496
Conversation
|
@sayamkanwar how is this different from your work in #477 ? |
|
Also @Ram81, what else does the task demand? Wasn’t that the only correction in this task? |
| next_layer_id = request.POST.get('nextLayerId') | ||
| public_sharing = True | ||
| user = None | ||
| public_sharing = True |
There was a problem hiding this comment.
This was necessary because then the model would not be shared and hence the canvas will not render the comments and sharing stuff on the model.
| except: | ||
| return JsonResponse({'result': 'error', 'error': str(sys.exc_info()[1])}) | ||
|
|
||
| if Network.objects.filter(name=net_name).exists(): |
There was a problem hiding this comment.
That's why there is an if statement, if this returns true then this will be executed. Else it will create a new model record.
There was a problem hiding this comment.
If the result is null, it will return false
| user_id = int(user_id) | ||
| user = User.objects.get(id=user_id) | ||
| # load the model with the net name | ||
| model = Network.objects.get(name=net_name) |
There was a problem hiding this comment.
Why are we using net_name as a unique key?
There was a problem hiding this comment.
We are using net_name as a unique key because the only similarity between the new model and already existing model would be the model name. That's why I can't use anything else like id.
| user = User.objects.get(id=user_id) | ||
| # load the model with the net name | ||
| model = Network.objects.get(name=net_name) | ||
| model_id = model.id |
There was a problem hiding this comment.
Isn't there any better way to handle this for anonymous sessions?
|
@Ram81, I'm sorry I had to abandon this task as I could not understand what to do in this. But I would like to work on this after the contest too. |
|
Closing this as student has abandoned the task |
2 participants
Hi,
I have fixed the bug in the share model feature which generated different URLs every time. Now it generates only one URL for a model.
Here's a demo
Please review @Ram81 @RishabhJain2018
Thank you! :)