Skip to content

Add Dark Theme - #394

Open
Jatana wants to merge 4 commits into
Cloud-CV:masterfrom
Jatana:master
Open

Add Dark Theme#394
Jatana wants to merge 4 commits into
Cloud-CV:masterfrom
Jatana:master

Conversation

@Jatana

@Jatana Jatana commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

Add dark ui mode for the fabrik.

@Ram81

Ram81 commented Oct 26, 2018

Copy link
Copy Markdown
Member

@Jatana can you also share a screenshot of the UI

@Jatana

Jatana commented Oct 26, 2018

Copy link
Copy Markdown
Contributor Author

@Ram81, here the sample - https://imgur.com/eYeyVyi

@Ram81

Ram81 commented Oct 26, 2018

Copy link
Copy Markdown
Member

@Jatana can you make toggle button similar to the following image.
toggle
And why is there a Alpha button on canvas?

@Jatana

Jatana commented Oct 26, 2018

Copy link
Copy Markdown
Contributor Author

Alpha It is changed 'Net Name'

Comment thread ide/static/css/style.css
bottom: 0px;
width: 20%;
background-color: #F3F3F3;
}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 55e8068.

Comment thread ide/static/css/style.css
position: relative;
overflow: scroll;
// overflow: scroll;
border: 1px solid #ddd;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment this?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 5e83dc8.

Comment thread ide/static/css/style.css Outdated
left: 0;
right: 0;
top: 15px;
right: 305px;

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix alignment of netName control it isn't placed in center of the canvas.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 5e83dc8.

@Ram81

Ram81 commented Oct 26, 2018

Copy link
Copy Markdown
Member

@Jatana good work overall. Few changes:

  • It seems you have modified style for existing layer component size. Layer height seems to be smaller to previous design. It affects our visualization algorithm so please revert the layer height.
  • ModelZoo of Fabrik doesn't match dark theme.
  • Also model name div seems to get displaced when scrolled, please revert that to original one.
    abc
    abcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants