Skip to content

Raredisease add concatenated SNV file for loqusDB - #172

Merged
peterpru merged 9 commits into
mainfrom
rd-store-loqus-snv-file
Sep 1, 2026
Merged

Raredisease add concatenated SNV file for loqusDB#172
peterpru merged 9 commits into
mainfrom
rd-store-loqus-snv-file

Conversation

@peterpru

@peterpru peterpru commented Aug 21, 2026

Copy link
Copy Markdown
Member

Description

For Raredisease loqusDB uploads we need to have a file that combines both the genome-wide SNVs and the MT variants. This PR adds this output to housekeeper. Parent issue here: https://github.com/Clinical-Genomics/MTP-RAREDISEASE/issues/172

To be deployed with the corresponding servers PR.

Added

  • raredisease loqusdb SNV files in housekeeper

Changed

Fixed

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy rd-store-loqus-snv-file
hermes-test --help
us
bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-servers-stage.sh rd-store-loqus-snv-file
cg workflow raredisease store evolvedsalmon

How to test

  • login to hasta, do the prep above
  • do the store command:

Expected test result

  • check that the files are included with the correct tags
  • Take a screenshot and attach or copy/paste the output.
  • [ ]
image image

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@peterpru peterpru self-assigned this Aug 21, 2026
@peterpru
peterpru requested a review from a team as a code owner August 21, 2026 08:44
@codecov-commenter

codecov-commenter commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.92%. Comparing base (4a6315e) to head (1330df1).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   92.91%   92.92%   +0.01%     
==========================================
  Files          28       28              
  Lines        1030     1032       +2     
==========================================
+ Hits          957      959       +2     
  Misses         73       73              
Flag Coverage Δ
unittests 92.92% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sofiademmou sofiademmou left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 👍

@peterpru
peterpru merged commit 1bb4896 into main Sep 1, 2026
3 checks passed
@peterpru
peterpru deleted the rd-store-loqus-snv-file branch September 1, 2026 06:42
@peterpru

peterpru commented Sep 1, 2026

Copy link
Copy Markdown
Member Author
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants