fix: drop polonius-the-crab, inline unsafe reborrow - #404
Conversation
- fxhash (RUSTSEC-2025-0057, unmaintained) -> rustc-hash 2.x - linked-hash-map (no releases since 2020) -> indexmap (already a dep) - cargo update for semver-compatible bumps
1f3013e to
c4c6138
Compare
…436) - Drop polonius-the-crab and 3 transitive deps (paste, higher-kinded-types, macro_rules_attribute) — clears RUSTSEC-2024-0436 (paste unmaintained) - Inline the raw-pointer reborrow that polonius wrapped behind a macro - Fix rustfmt.toml edition 2021 -> 2024 to match Cargo.toml
4 mock-based tests (no ClickHouse needed) + 3 integration tests covering the unsafe reborrow paths in poll_next and Next::poll: - single row, multi-row, empty result, fetch_all/fetch_one (mock) - large result spanning chunks, borrowed rows, small block size (integration)
Strip informal phrasings ("we hate", "needs therapy", "buy it a beer")
and replace em-dashes with ASCII punctuation to match project style.
Technical content unchanged.
c4c6138 to
b44c423
Compare
|
Closing this in favour of a fresh upstreaming approach. We're consolidating our upstream-targeted work onto a new The polonius removal lands first as #422 (already rebased on Sorry for the noise, people. |
polonius-the-crab has so many abandonment issues it needs therapy --
two RustSec advisories across its transitive deps, the whole tree
stagnant for 12+ months. Four crates for a macro that expands to
one line of unsafe.
Inlined the raw-pointer reborrow with a full safety proof and
documentation of every alternative we tried (and why none compiled
without unsafe). Removes 4 crates, clears 2 advisories.