Implement support for jiff - #293
Open
NickKolpinski wants to merge 12 commits into
Open
Conversation
|
|
serprex
previously approved these changes
Sep 22, 2025
Author
|
I just realized that BurntSushi wanted to release jiff 1.0 in the near future:
While it's almost October, that still means that the release might be right around the corner. Let's put this PR on hold for now. |
NickKolpinski
marked this pull request as draft
September 27, 2025 13:47
Contributor
|
Updated comment on supporting Jiff here: #383 (comment) |
NickKolpinski
force-pushed
the
feat/jiff-support
branch
from
June 1, 2026 20:13
86f6c42 to
2bc061a
Compare
Author
|
Integration tests are yet to be ported, but I pushed the interface, so you can take a look. @BurntSushi, I believe you also wanted to be pinged. |
Unsure why rust-analyzer's "implement missing members" didn't care about `use core::fmt` at the top of the files, but oh well.
This should be less of a pain to use when type inference can't be relied upon.
NickKolpinski
marked this pull request as ready for review
June 2, 2026 21:10
NickKolpinski
requested review from
joe-clickhouse,
kavirajk and
peter-leonov-ch
as code owners
June 2, 2026 21:10
The signs need to match for negative `SignedDuration`s.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement support for jiff.
It's a somewhat new datetime library, inspired by JavaScript's Temporal. Unlike
chronoandtime, it supports TZif files out of the box, which is why I prefer it to the other two.The PR is heavily based on the
chronoimplementation.Checklist
Delete items not relevant to your PR: