feat: add interval type support for RowBinaryWithNamesAndTypes - #277
Merged
Conversation
Contributor
|
Thanks for your contribution!
yeah, seems to be a correct assumption: curl -XPOST "http://localhost:8123?default_format=RowBinaryWithNamesAndTypes" \
--data-binary "SELECT toIntervalYear(-42) AS y" > out.binyields
Since you are changing validation too, could you add more integration tests for that? See https://github.com/ClickHouse/clickhouse-rs/blob/main/tests/it/rbwnat.rs on the current main branch. I think just a few SELECT queries with min int64, zero, max int64 values for all interval units will be enough. NB: it is possible to run something like CREATE TABLE foobar
(
`i` IntervalYear
)
ENGINE = Memorywhich is described as DESCRIBE TABLE foobar
┌─name─┬─type─────────┬─default_type─┬─default_expression─┬─comment─┬─codec_expression─┬─ttl_expression─┐
1. │ i │ IntervalYear │ │ │ │ │ │
└──────┴──────────────┴──────────────┴────────────────────┴─────────┴──────────────────┴────────────────┘so we'll need to add integration tests for insert after #244, too |
Contributor
|
Clippy issues are fixed on main. |
timvermeulen
force-pushed
the
rbwnat-intervals
branch
from
August 25, 2025 13:14
8fa6105 to
638af2f
Compare
Contributor
Author
|
Thanks for the pointers! I've added an integration test. |
slvrtrn
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds
Intervaltype support forRowBinaryWithNamesAndTypes.I added conversions to/from
SerdeType::I64because that seems to be how ClickHouse stores interval values, though https://clickhouse.com/docs/sql-reference/data-types/special-data-types/interval says "Time interval as an unsigned integer value.", so let me know ifSerdeType::I64is the appropriate type here.