Repository navigation
ci: repair red main (aarch64 dead code, stale validator test, notices flake) - #2
Merged
Merged
Conversation
…s flake Three independent causes had left CI red on main since 2026-09-09: - layers.rs: gate schraudolph_exp to x86_64. Its only callers are the AVX2 SiLU and softmax scalar tails, both #[cfg(target_arch = "x86_64")], so on aarch64 (macos-15, Apple Silicon) the function was dead code and clippy -D warnings failed. Gating the definition to match the callers fixes it. - test_raimodel.py: the reader's kernel maximum is 1024 (gemm.rs MAX_GROUPS, raimodel MAX_GEMM_GROUPS), but test_validate_model_config still fed it 128-era configs (144 and 158 groups) that the validator now correctly accepts, so the expected "kernel maximum" rejection never fired. Use group_size=12 (1195 linear groups) and embed_group_size=2 (2048 embedding groups) so the rejection fires against the real limit. - ci.yml: the third-party-notices gate hard-failed when api.clearlydefined.io was unreachable, rotting main on a transient outage. When every retry fails the regenerated file is incomplete and the diff is a false positive, so warn and skip the inconclusive comparison; a genuinely stale file is still caught on any run where the lookup succeeds.
cargo audit flagged rustls 0.23.37 (RUSTSEC-2026-0285: TLS 1.3 handshake messages accepted across encryption-level boundaries, medium, fixed in 0.23.45). Semver-compatible patch (pulls rustls-webpki 0.103.15); lockfile-only. The advisory was published after this branch's earlier audit passed — the advisory-DB update that turned the gate red.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ci: repair red main — aarch64 dead code, stale validator test, notices flake
Three independent causes had left CI red on main since 2026-09-09:
layers.rs: gate schraudolph_exp to x86_64. Its only callers are the AVX2
SiLU and softmax scalar tails, both #[cfg(target_arch = "x86_64")], so on
aarch64 (macos-15, Apple Silicon) the function was dead code and clippy
-D warnings failed. Gating the definition to match the callers fixes it.
test_raimodel.py: the reader's kernel maximum is 1024 (gemm.rs MAX_GROUPS,
raimodel MAX_GEMM_GROUPS), but test_validate_model_config still fed it
128-era configs (144 and 158 groups) that the validator now correctly
accepts, so the expected "kernel maximum" rejection never fired. Use
group_size=12 (1195 linear groups) and embed_group_size=2 (2048 embedding
groups) so the rejection fires against the real limit.
ci.yml: the third-party-notices gate hard-failed when api.clearlydefined.io
was unreachable, rotting main on a transient outage. When every retry fails
the regenerated file is incomplete and the diff is a false positive, so warn
and skip the inconclusive comparison; a genuinely stale file is still caught
on any run where the lookup succeeds.