test: Support configurable navigation timeout and increase it for Windows tests - #2482
Open
nattallius wants to merge 1 commit into
Open
test: Support configurable navigation timeout and increase it for Windows tests#2482nattallius wants to merge 1 commit into
nattallius wants to merge 1 commit into
Conversation
OrKoN
reviewed
Aug 6, 2026
| this.pptrPage, | ||
| cpuMultiplier, | ||
| networkMultiplier, | ||
| navigationTimeout, |
Collaborator
There was a problem hiding this comment.
navigation timeout in the WaitForHelper is a different timeout IIUC. I think we should not pass this.#navigationTimeout * networkMultiplier * cpuMultiplier as navigation timeout for WaitForHelper here. Additionally, I do not think the WaitForHelper timeout was the cause of flakiness.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a configurable navigation timeout to McpContext options, allowing tests to override the default 10-second limit. We use this in
tests/utils.tsto set a 20-second timeout on Windows. This potentially fixes flaky test timeouts on slow Windows environments by ensuring that both direct navigations and click-triggered navigations (which use WaitForHelper) are synchronized to the longer 20-second limit and are not reset back to 10 seconds during emulation.