Skip to content

Use Context Manager to Close h5py.File After Use #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
electronsandstuff wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use Context Manager to Close h5py.File After Use #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb82d05
use context manager to close `h5py.File` after use
electronsandstuff Jun 30, 2026
ebd931d
lint
electronsandstuff Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions beamphysics/particles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import Sequence, Union

import numpy as np
from h5py import File
from h5py import File, Group

from . import statistics
from .interfaces import bmad
Expand Down Expand Up @@ -1356,16 +1356,24 @@ def write(self, h5, name=None) -> None:
"""
if isinstance(h5, (str, pathlib.Path)):
fname = os.path.expandvars(h5)
g = File(fname, "w")
pmd_init(g, basePath="/", particlesPath="particles")
g = g.create_group("particles")
with File(fname, "w") as f:
pmd_init(f, basePath="/", particlesPath="particles")
g = f.create_group("particles")
write_pmd_bunch(g, self, name=name)

# Note: h5py.File is an h5py.Group so this check needs to be first
elif isinstance(h5, File):
pmd_init(h5, basePath="/", particlesPath="particles")
g = h5.create_group("particles")
else:
g = h5
write_pmd_bunch(g, self, name=name)

elif isinstance(h5, Group):
write_pmd_bunch(h5, self, name=name)

write_pmd_bunch(g, self, name=name)
else:
raise ValueError(
f"Expected path, h5py.File, or h5py.Group. Got {type(h5)} instead."
)

# Plotting
# --------
Expand Down
Loading