feat: Always render single/multi selection options vertically (M2-10899) - #758
Open
hotavocado wants to merge 1 commit into
Open
feat: Always render single/multi selection options vertically (M2-10899)#758hotavocado wants to merge 1 commit into
hotavocado wants to merge 1 commit into
Conversation
Single and multiple selection items now render options in one vertical column at every breakpoint, replacing the two-column split that applied at >=600px. This is the layout already used below 600px, now applied consistently. No configuration flag: the multi-column approach is dropped entirely rather than gated per item, so existing items pick up the new layout automatically. Portrait (tile style) responses are unaffected. Removes splitList and the now-unused useCustomMediaQuery imports, which had no remaining callers. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
divbzero
self-requested a review
August 4, 2026 13:20
divbzero
approved these changes
Aug 4, 2026
Contributor
|
Do not merge yet. Wait for QA confirmation. |
Contributor
|
Also wait to add an admin banner / notify admin users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
🔗 Jira Ticket M2-10889
Single and multiple selection items now render their options in one vertical column at every breakpoint, replacing the two-column split that applied at ≥600px.
This is the layout the app already used below 600px, so it is an existing, validated design now applied consistently across all widths.
Per the discussion on M2-10899, this assumes no configuration flag. Rather than gate the old and new layouts per item, we are dropping the multi-column approach entirely and always going vertical, to keep behavior consistent across breakpoints and platforms. Existing items pick up the new layout automatically — there is no per-item setting, no backend field, and no admin panel change.
Portrait (tile style) responses are unaffected:
PortraitGridkeeps its current wrapping grid.Changes
RadioItem/RegularGrid.tsxandCheckboxItem/RegularGrid.tsxrender a single flex column atgap="16px". Option cards span the parent's full width via the defaultalign-items: stretch, so no explicit width rule was needed.splitList(src/shared/utils/helpers/splitList.ts) and its barrel export. It was the two-column helper and had no other callers or tests.useCustomMediaQueryimports from both grids —lessThanSMwas their only consumer.Padding, gap, and card styling are unchanged. Option ordering,
randomizeOptions, hidden-option filtering, tooltips, images, and palette colors are all untouched.Net: 41 insertions, 115 deletions.
Testing
yarn tsc --noEmit— 0 errorsyarn lint:check— 0 errors, 32 warnings (unchanged fromdev; none introduced by this change)yarn test— 751 passed / 44 filesChecklist
Functionality
Testing
Security & Data Privacy
Logging/Monitoring
Performance
Readability
Change Safety
Backend changes are backwards compatible with old clients, or it is well known they are not and a deployment/rollout plan is in place. This include backend changes being compatible with old mobile app versions, as well as applet versioning within Curious.Destructive database migrations are rolled out in stages. For example, renaming a column means adding a new column and migrating the existing data to that columns in one deployment. Then monitoring to ensure that field isn’t used, and finally removing that old column in a separate deployment.