Skip to content

fix: Regression fix Radio button tests failing (M2-8992) #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SebasYanik wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix: Regression fix Radio button tests failing (M2-8992) #634

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34398a0
fix: Regression fix Radio button tests failing (m2-8992)
SebasYanik Jun 13, 2025
879ef15
Fix
SebasYanik Jun 13, 2025
075155c
Added back comment for kebab-case
Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 12 additions & 13 deletions src/shared/ui/Items/SelectBase/SelectBaseText.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ type Props = {

export const SelectBaseText = (props: Props) => {
const { processedWords } = useCustomWordWrap(props.text);
const hasLongWord = processedWords.some(({ needsWrap }) => needsWrap);

return (
<Text
Expand All @@ -22,23 +23,21 @@ export const SelectBaseText = (props: Props) => {
cursor: 'pointer',
lineBreak: 'normal',
display: '-webkit-box',

// Using kebab-case (i.e. `-webkit-some-things`) would cause warnings
// in the JS console about kebab-case being not supported for CSS
// properties.
Comment thread
sricharan-varanasi marked this conversation as resolved.
webkitLineClamp: '3',
webkitBoxOrient: 'vertical',
}}
>
{processedWords.map(({ word, needsWrap, ref }, index) => {
return needsWrap ? (
<span ref={ref} style={{ wordBreak: 'break-word' }} key={index}>
{`${word} `}
</span>
) : (
`${word} `
);
})}
{hasLongWord
? processedWords.map(({ word, needsWrap, ref }, index) =>
needsWrap ? (
<span ref={ref} style={{ wordBreak: 'break-word' }} key={index}>
{`${word} `}
</span>
) : (
`${word} `
),
)
: props.text}
</Text>
);
};