Repository navigation
AST-171789 Fail marketplace release step on HTTP error - #359
Merged
cx-lior-poterman merged 1 commit intoSep 1, 2026
Merged
Conversation
The JetBrains marketplace upload used plain curl -i, which exits 0 even when the marketplace responds with an HTTP error. A prior release was rejected with a 403 but the workflow reported success, so the plugin silently failed to publish and nobody noticed until a developer checked the marketplace manually. Add --fail-with-body to both curl calls so the step exits non-zero on HTTP >= 400 while still printing the response body for diagnosis. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
cx-atish-jadhav
self-requested a review
September 1, 2026 07:04
cx-atish-jadhav
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The marketplace upload step used plain
curl -i, which exits 0 even when JetBrains returns an HTTP error. A recent release was rejected with a 403 but the workflow reported success, so the plugin never actually published and it went unnoticed until someone checked the marketplace directly.This adds
--fail-with-bodyto both curl calls so the step fails on HTTP >= 400 while still logging the response body for diagnosis. Releases that were silently failing before will now fail loudly, which is the point.