-
Notifications
You must be signed in to change notification settings - Fork 25
Update solana installation instructions #474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from 1 commit
fa502b4
80813c4
574769a
8b73144
02e292e
7fce258
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,27 +11,34 @@ Begin by following the steps in the {ref}`Certora Prover installation guide <ins | |
|
|
||
| `curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh` | ||
|
|
||
| It is useful to have Rust versions 1.75, 1.79, and 1.81 or above installed. | ||
| It is useful to have Rust versions 1.75, 1.79, and 1.85 or above installed. | ||
|
|
||
| ``` | ||
| rustup toolchain install 1.79 | ||
| rustup toolchain install 1.75 | ||
| rustup toolchain install 1.81 | ||
| rustup toolchain install 1.85 | ||
| ``` | ||
|
|
||
| 2. Install `certora-sbf` cargo sub-command | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's also add a link to the sources: https://github.com/Certora/cargo-certora-sbf |
||
|
|
||
| `cargo +1.81 install cargo-certora-sbf` | ||
| `cargo +1.85 install cargo-certora-sbf` | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the README of https://github.com/Certora/cargo-certora-sbf we don't state a version, I think we should keep it in sync? |
||
|
|
||
| Note that a minimal version of Rust required to install `certora-sbf` is | ||
| v1.81. | ||
| v1.85. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is confusing, above we state 1.79 and 1.75 but then we say 1.81 is actually required for Nevertheless, I would remove this line as it's more confusing then it adds value.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think the certora-sbf readme is helpful for understanding this:
so it seems this is about needing the new one (now 1.85) to be able to install the sbf, but it may still use the others somehow? wdyt?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. reading that readme part also makes me wonder if we should have that optional solana CLI step here too? |
||
|
|
||
| 3. Test the installation by using `certora-sbf` to download and install Certora | ||
| Platform Tools | ||
|
|
||
| `cargo certora-sbf --no-build` | ||
|
|
||
| 4. It is strongly recommended to install VSCode and the rust-analyzer extension. | ||
| 4. Install [llvm](https://releases.llvm.org/), you can typically install it also via apt or brew. | ||
|
|
||
| 5. Install [rustfilt](https://github.com/luser/rustfilt) | ||
| ``` | ||
| cargo install rustfilt | ||
| ``` | ||
|
|
||
| 7. It is strongly recommended to install VSCode and the rust-analyzer extension. | ||
|
|
||
| ---- | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the old versions there actually still useful?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rather state "tested on 1.85" and we should just keep the block below as: