Skip to content

Improve Homarid Spawning Bed AI #11717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
vanja-ivancevic wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −3
Draft

Improve Homarid Spawning Bed AI #11717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions forge-ai/src/main/java/forge/ai/ComputerUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3253,9 +3253,10 @@ public static boolean shouldSacrificeThreatenedCard(Player ai, Card c, SpellAbil
return false; // no use in sacrificing a card in an attempt to regenerate it
}
Combat combat = ai.getGame().getCombat();
boolean isThreatened = (c.isCreature() && ComputerUtil.predictCreatureWillDieThisTurn(ai, c, sa, false)
// The payoff does not save the sacrificed card, so assess the pending threat on its own.
boolean isThreatened = (c.isCreature() && ComputerUtil.predictCreatureWillDieThisTurn(ai, c, null, false)
&& !ComputerUtilCombat.willOpposingCreatureDieInCombat(ai, c, combat) && !ComputerUtilCombat.isDangerousToSacInCombat(ai, c, combat))
|| (!c.isCreature() && ComputerUtil.predictThreatenedObjects(ai, sa).contains(c));
|| (!c.isCreature() && ComputerUtil.predictThreatenedObjects(ai, null).contains(c));
return isThreatened;
}

Expand Down
8 changes: 8 additions & 0 deletions forge-ai/src/main/java/forge/ai/ability/TokenAi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,10 @@ public class TokenAi extends SpellAbilityAi {

@Override
protected boolean checkPhaseRestrictions(final Player ai, final SpellAbility sa, final PhaseHandler ph) {
if (ComputerUtil.activateForCost(sa, ai)) {
return true;
}

final Card source = sa.getHostCard();
// Planeswalker-related flags
boolean pwMinus = false;
Expand Down Expand Up @@ -133,6 +137,10 @@ protected boolean checkPhaseRestrictions(final Player ai, final SpellAbility sa,

@Override
protected AiAbilityDecision checkApiLogic(final Player ai, final SpellAbility sa) {
if (ComputerUtil.activateForCost(sa, ai)) {
return new AiAbilityDecision(100, AiPlayDecision.WillPlay);
}

final Game game = ai.getGame();
final Player opp = ai.getWeakestOpponent();

Expand Down
1 change: 0 additions & 1 deletion forge-gui/res/cardsfolder/h/homarid_spawning_bed.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ ManaCost:U U
Types:Enchantment
A:AB$ Token | Cost$ 1 U U Sac<1/Creature.Blue/blue creature> | TokenAmount$ X | TokenScript$ u_1_1_camarid | TokenOwner$ You | SpellDescription$ Create X 1/1 blue Camarid creature tokens, where X is the sacrificed creature's mana value.
SVar:X:Sacrificed$CardManaCost
AI:RemoveDeck:All
SVar:NonStackingEffect:True
Oracle:{1}{U}{U}, Sacrifice a blue creature: Create X 1/1 blue Camarid creature tokens, where X is the sacrificed creature's mana value.