Add withVoidBelowLevel to ImportHeightMapOp.java - #497
Open
HydrolienF wants to merge 1 commit into
Open
Conversation
Author
|
Any news on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've add that function to avoid having ocean generated outside of a HeightMap when using
withWaterLevelwith wpscripts.I think having ocean outside of the HeightMap is an unwanted behavior (#496), but this pull request keep the same behavior by default as before.
I've tried to match the exact same code style and to do as few changes as possible.
You can use this code by merging or by copying it as you like. You can use it under any licences and you don't need to name me anywhere.
I would love to have that extra
withVoidBelowLevel(int voidBelowLevel)function for my scripts on the main worldpainter version.