>50% perf improvement and >50% reduction in ram usage - #478
Draft
MCRcortex wants to merge 1 commit into
Draft
Conversation
Owner
|
Sounds promising! As you might have noticed I have already integrated some of your suggested changes, so you might want to rebase. |
…ements to ram usage (>50% reduction in ram usage (probably near 60%))
Author
|
have also updated util pr to include the missing UnsafeRandom.fastNextInt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performance is compared to 2.24.4, ram usage is probably more than 50% and near 60 reduction, this is a draft as its ment to show as an example of one way, it requires some of the other prs have done for the progressreciever to not be a bottleneck on my laptop (16 threads(6p 4e)). there are many other things such as not using strings for type testing or parsing properties (e.g. Integer.parse) whenever blockstate properties are accessed which would provide significant increase in performance. current implementation is also not optimal (nor am sure if 100% correct but thinks is) as it does a for loop to find block state index in pallet even when it is fairly large, (>16/32) which should be replaces with a Reference2Short hashmap (from fastutils) which should improve block setting speed in large palleted chunk sections