fix(stats): address success rate review comments from #2988 - #2990
Conversation
- Include install/fail-only apps in global_stats total (drop get>0 filter) - Drive public headline+daily from app_log like dimensional breakdowns
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
|



Summary (AI generated)
getUpdateStatsCFandget_update_stats()now include apps with install/fail outcomes even when nogetevent occurred in the snapshot window./dataheadline + daily success rate now uses the sameapp_logset/failure event stream as platform/country/version breakdowns.Motivation (AI generated)
Follow-up to #2988 review comments: the global success rate still dropped install/fail-only apps due to a
get > 0filter, and public headline metrics mixedversion_usagewithapp_logbreakdowns.Business Impact (AI generated)
More accurate global_stats snapshots and internally consistent public success rate numbers across headline and dimensional views.
Test Plan (AI generated)
bunx vitest run tests/public-live-update-metrics.unit.test.ts tests/public-stats.unit.test.ts/private/website_stats/live_updatesheadline vs platform breakdown success rates after deployglobal_statscron stores success_rate including install/fail-only appsGenerated with AI
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.