Skip to content

fix(cli): throw CliUserError from login expected failures #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
posthog-eu wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −2
Draft

fix(cli): throw CliUserError from login expected failures #2956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cli/src/login.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export async function loginInternal(apikey: string, options: Options, silent = f
if (!apikey) {
if (!silent)
log.error('Missing API key, you need to provide an API key to upload your bundle')
throw new Error('Missing API key')
throw new CliUserError('Missing API key')
}

if (!silent)
Expand All @@ -47,7 +47,7 @@ export async function loginInternal(apikey: string, options: Options, silent = f
if (local && !existsSync('.git')) {
if (!silent)
log.error('To use local you should be in a git repository')
throw new Error('Not in a git repository')
throw new CliUserError('Not in a git repository')
}

// Validate, persist (0o600) and emit the login event via the shared auth core.
Expand Down
3 changes: 3 additions & 0 deletions cli/test/test-posthog-exception.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ try {
// never opens an error tracking issue.
assert.equal(shouldCapturePosthogException(new CliUserError('Login cancelled')), false)
assert.equal(shouldCapturePosthogException(new CliUserError('Upload cancelled by user')), false)
// `login --local` outside a git repository is a normal user mistake the CLI
// already handles cleanly, so it throws CliUserError and never opens an issue.
assert.equal(shouldCapturePosthogException(new CliUserError('Not in a git repository')), false)
// Two failures on different channels must be treated identically (one issue,
// not one per channel), since the channel name lives in context, not the message.
assert.equal(
Expand Down
Loading