mcreator@2025.1: Add manifest for MCreator app - #1405
Open
m-saliola wants to merge 5 commits into
Open
Conversation
6 tasks
Contributor
|
/verify |
Contributor
|
All changes look good. Wait for review from human collaborators. mcreator
|
Contributor
|
I think it would be beneficial to include more manifest details like |
Contributor
|
Your changes do not pass checks. mcreator
|
Calinou
reviewed
May 26, 2025
Calinou
reviewed
May 26, 2025
Comment on lines
+12
to
+18
| "bin": "MCreator20251/mcreator.exe", | ||
| "shortcuts": [ | ||
| [ | ||
| "MCreator20251/mcreator.exe", | ||
| "MCreator" | ||
| ] | ||
| ], |
Owner
There was a problem hiding this comment.
Use "extract_dir": "MCreator20251" so that the top-level folder isn't present (we don't need it, and its name is version-specific).
extract_dir should also be specified in autoupdate using the $cleanVersion placeholder (which is like $version but with periods removed).
Contributor
There was a problem hiding this comment.
@MBrine85 You can check this wiki for more information about version variables:
https://github.com/ScoopInstaller/Scoop/wiki/App-Manifest-Autoupdate#version-variables
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a Scoop manifest for MCreator version 2025.1
Tested locally, installs and runs fine.