fix(ping): make IPv4 and IPv6 ICMP polling safe

CHANGELOG

@@ -26,6 +26,10 @@ The Cacti Group | spine
 -issue#552: Terminate die() output so consecutive fatal messages no longer run together
 -issue#561: Reserve room for the terminator in php_readpipe() so a full script server result cannot write past result_string
 -issue#562: Escalate PHP script server shutdown to SIGKILL after a bounded grace period so a stuck child is not orphaned
+-issue#593: Release the ICMP packet and socket through one cleanup path, including the FD_SETSIZE exit
+-issue#597: Pair one capability decision with each raw-socket lock/elevation block and release LOCK_SETEUID before retrying
+-issue#597: Release Linux capability handles on every probe path and log an absent optional CAP_NET_RAW capability as a warning
+-issue#611: Leave hostinfo untouched when getaddrinfo() fails in init_sockaddr()
 -issue: Correct signed and unsigned printf format specifiers in poller.c, free session.localname on the unknown-version return in snmp.c, and quote shell variables in the build scripts
 -issue: Escape the SNMP result and RRD name before the poller_output INSERT, bound the buffer_output_errors write to the space left in error_string, and validate the --hostlist argument before it reaches SQL
 -issue: Restore the twelve headers and spine.conf.dist missing from the dist tarball so a release tarball can be compiled from

Makefile.am

@@ -65,7 +65,8 @@ check_PROGRAMS += \
 	tests/unit/test_util_strings \
 	tests/unit/test_build_fixes \
 	tests/unit/test_safety_fixes \
-	tests/unit/test_linked
+	tests/unit/test_linked \
+	tests/unit/test_ping_icmp
 endif
 
 # test_util_strings pulls in common.h and the sources under test, so it needs
@@ -86,4 +87,7 @@ tests_unit_test_linked_SOURCES = tests/unit/test_linked.c tests/fuzz/stubs.c \
 	sql.c util.c snmp.c locks.c poller.c nft_popen.c php.c ping.c keywords.c error.c
 tests_unit_test_linked_LDADD   = $(CMOCKA_LIBS) $(LIBS)
 
+tests_unit_test_ping_icmp_SOURCES = tests/unit/test_ping_icmp.c tests/fuzz/stubs.c \
+	sql.c util.c snmp.c locks.c poller.c nft_popen.c php.c keywords.c error.c
+tests_unit_test_ping_icmp_LDADD   = $(CMOCKA_LIBS) $(LIBS)
 TESTS = $(check_PROGRAMS)

common.h

@@ -111,6 +111,14 @@
 #  include <netinet/ip_icmp.h>
 #endif
 
+#if HAVE_NET_IF_H
+#  include <net/if.h>
+#endif
+
+#if HAVE_IFADDRS_H
+#  include <ifaddrs.h>
+#endif
+
 #if HAVE_SYS_TIME_H
 #  include <sys/time.h>
 #endif

configure.ac

@@ -132,6 +132,7 @@ AC_SEARCH_LIBS([clock_gettime], [rt pthread])
 AC_CHECK_HEADERS(sys/socket.h sys/select.h sys/wait.h sys/time.h)
 AC_CHECK_HEADERS(assert.h ctype.h errno.h signal.h math.h malloc.h netdb.h)
 AC_CHECK_HEADERS(signal.h stdarg.h stdio.h syslog.h)
+AC_CHECK_HEADERS(ifaddrs.h net/if.h)
 AC_CHECK_HEADERS(
   netinet/in_systm.h netinet/in.h netinet/ip.h netinet/ip_icmp.h,
   [],
@@ -155,7 +156,7 @@ AC_CHECK_TYPES([unsigned long long, long long])
 AC_TYPE_SIZE_T
 
 # Checks for library functions.
-AC_CHECK_FUNCS(malloc calloc gettimeofday strerror strtoll)
+AC_CHECK_FUNCS(malloc calloc gettimeofday strerror strtoll getifaddrs if_nametoindex)
 
 # ****************** Solaris Privileges Check ***********************