ci: measure coverage with xdebug instead of pcov - #279
Merged
Merged
Conversation
The "Enforce coverage of changed lines" gate measured 0 lines because pcov only instruments files under its auto-detected directory (the Composer root / vendor parent), which excludes cacti/plugins/<plugin> when Pest runs from the cacti/ checkout. xdebug instruments every executed file, so changed-line coverage is measured correctly. Matches the driver the rest of the plugin fleet uses.
TheWitness
requested review from
bmfmancini,
browniebraun,
cigamit and
xmacan
and
a balanced review from Copilot
September 29, 2026 22:36
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused configuration change correctly addresses plugin source coverage without introducing unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Switches CI coverage instrumentation from PCOV to Xdebug so plugin source files are included in Clover reports and patch-coverage enforcement works correctly.
Changes:
- Configures Xdebug as the CI coverage driver.
- Documents the CI change in the changelog.
| File | Description |
|---|---|
.github/workflows/plugin-ci-workflow.yml |
Changes the PHP coverage driver to Xdebug. |
CHANGELOG.md |
Records the coverage-driver correction. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmfmancini
approved these changes
Sep 30, 2026
browniebraun
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switches the CI coverage driver from pcov to xdebug.
Why
The
Enforce coverage of changed linesgate (merged recently) was measuring0 lines: pcov only instruments files under its auto-detected directory
(the Composer root / vendor parent), which excludes
cacti/plugins/<plugin>when Pest runs from the
cacti/checkout. So the gate could never see theplugin's own source and would pass trivially (or block a real change with a
0%/absent-from-Clover result).
xdebug instruments every executed file, so changed-line coverage is measured
correctly. This matches the driver used by the rest of the plugin fleet.