Skip to content

ci(sanitize): refuse to move an existing release tag #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rob-p wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci(sanitize): refuse to move an existing release tag #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions .github/workflows/sanitize-cargo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,21 @@ jobs:
- name: Tag and push new commit
run: |
export VERSION_TAG=`cargo read-manifest | jq ".version" | tr -d '"'`
# Never move an existing release tag. A force-push of main (or any
# re-push whose head commit still carries [do_tag]) re-triggers this
# workflow on an already-released version; force-tagging there would
# silently repoint the tag at a fresh commit and change the checksum
# of GitHub's generated source tarball for downstream packagers
# (see issue #73). Re-releasing a version now requires deleting the
# tag by hand first.
if git ls-remote --exit-code --tags origin "refs/tags/v${VERSION_TAG}" >/dev/null 2>&1; then
echo "::error::tag v${VERSION_TAG} already exists on origin; refusing to move it. Bump the version, or delete the tag manually to re-release."
exit 1
fi
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
git config --local user.name "github-actions[bot]"
git add Cargo.toml.cs_orig
git add Cargo.toml
git commit -m "create sanitized release"
git tag --force -a v${VERSION_TAG} -m "version ${VERSION_TAG}"
git push --force origin v${VERSION_TAG}
git tag -a v${VERSION_TAG} -m "version ${VERSION_TAG}"
git push origin v${VERSION_TAG}
Loading