Repository navigation
One click remove timeslot - #169
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Step 3 of booking creation, a selected time slot could only be removed by double-clicking it on the calendar, or by clicking the ✖ on its chip in the "Selected time slot(s)" list above. Double-click is hard to discover. This PR adds an X to the slot itself so one click removes it.
What changed
Screenshot
Where to look
calendar-booking-event.tsx: renders the X when anonRemoveEventprop is passed and the slot has no status. The click is stopped so it doesn't also select the slot.booking-calendar.tsx: new optionalonRemoveEventprop, passed into each event. Other calendars don't pass it, so they show no X.booking-creation-time-slot-selector.tsx: passes the existingremoveNewBookingasonRemoveEvent. No new removal logic.calendar-booking-event.module.scss: places the X 0.65rem from the top and right edges, and hides it in Month view.Testing
tsc --noEmitpasses.