fix: report column for multiline lookahead matches - #3506
Open
leroiu wants to merge 2 commits into
Open
Conversation
When a multiline regex uses a zero-width lookahead whose content spans more than MAX_LOOK_AHEAD bytes beyond the match boundary, the re-search in record_matches fails to find the match again and the printer falls back to sink_fast_multi_line, which drops the column number entirely. Insert a synthetic match covering the whole match range when the re-search yields no matches in multiline mode, so column reporting and other match-granularity output remain consistent. Closes BurntSushi#3503
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a multiline regex uses a zero-width lookahead whose content spans more than MAX_LOOK_AHEAD bytes beyond the match boundary, the re-search in record_matches fails to find the match again and the printer drops the column number entirely.
Insert a synthetic match covering the whole match range when the re-search yields no matches in multiline mode, so column reporting and other match-granularity output remain consistent.
Closes #3503
Tests
AI Disclosure
The fix was produced with the assistance of an AI coding agent. I have reviewed and understood the change as the contributor.