Skip to content

fix(providers): mount QueryClientProvider while the wagmi config loads #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sktbrd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(providers): mount QueryClientProvider while the wagmi config loads #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/app/web3-providers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,20 @@ export function Web3Providers({ children }: { children: React.ReactNode }) {
</ChainStoreProvider>
)

// `QueryClientProvider` has to wrap `stores` in BOTH branches. wagmi's config
// is created in the effect above, so on the first client render `config` is
// still null — and any component that calls `useQuery` while this branch is
// live throws "No QueryClient set". That is reachable from ordinary pages:
// `ProposalTransactionList` → `useDecodedTx` → `useQuery` renders during SSR,
// which took `/proposals/[id]` down with a 500. `queryClient` is a module
// singleton, so both branches share one cache and nothing is refetched when
// the config resolves and the tree swaps.
if (!config) {
return <Web3ReadyContext.Provider value={false}>{stores}</Web3ReadyContext.Provider>
return (
<Web3ReadyContext.Provider value={false}>
<QueryClientProvider client={queryClient}>{stores}</QueryClientProvider>
</Web3ReadyContext.Provider>
)
}

return (
Expand Down
Loading