fix(rf): route KeeLoq sub files to loopEmulate - #2822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes an issue in Sub-GHz transmission (
src/modules/rf/rf_send.cpp) where KeeLoq.subfiles failed to trigger interactive emulation.Previously,
sendCustomRF()only routed files toloopEmulate()ifdata.protocol == "RcSwitch". Because KeeLoq files save their protocol as"KeeLoq", they fell through totxSubFile(), which bypassed the interactive UI, counter stepping, and dynamic key generation.This change updates the condition to also match KeeLoq protocols (case-insensitively via
.equalsIgnoreCase("keeloq")), ensuring KeeLoq files are properly routed toloopEmulate()while keeping raw/static files ontxSubFile().Types of Changes
Bugfix
Verification
.subfile withProtocol: KeeLoqon LittleFS or SD Card.loopEmulate()(displaying interactive frequency, serial, button, counter, and payload info)..subfiles still correctly route totxSubFile().Testing
No testing needed since this is a straight forward fix.
Linked Issues
N/A
User-Facing Change
Further Comments
None