Skip to content
29 changes: 20 additions & 9 deletions .github/workflows/build-cli-release.reusable.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ on:
type: boolean
default: true
required: false

push:
branches:
- protoc-fix
env:
MACOSX_DEPLOYMENT_TARGET: "10.13"

Expand Down Expand Up @@ -69,6 +71,7 @@ jobs:
# shell: bash
# run: |
# ci/ubuntu-install-packages


- uses: dtolnay/rust-toolchain@stable
with:
Expand All @@ -81,6 +84,14 @@ jobs:

- name: Install protoc-gen-go
run: go install github.com/golang/protobuf/protoc-gen-go@latest

- name: Add protoc-gen-go to path
run: |
echo 'export PATH=$PATH:$HOME/go/bin' >> $GITHUB_ENV

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using 'export PATH=...' in GITHUB_ENV/GITHUB_PATH. Instead, echo just the directory (e.g. echo "$HOME/go/bin" >> $GITHUB_PATH) per GitHub Actions docs.

echo 'export PATH=$PATH:$HOME/go/bin' >> $GITHUB_PATH

- name: Call protoc-gen-go
run: protoc-gen-go --version

- name: Use Cross
if: contains(matrix._.os, 'ubuntu')
Expand Down Expand Up @@ -111,14 +122,14 @@ jobs:
workspaces: engine
prefix-key: "v5-rust-${{ matrix._.target }}"

# Build the CLI - Always use static-ssl features
- name: Build CLI Binary
# This single step now handles all builds
run: >
${{ env.CARGO }} build --release --bin baml-cli ${{ env.TARGET_FLAGS }}
--features static-ssl
--no-default-features
working-directory: engine
# # Build the CLI - Always use static-ssl features
# - name: Build CLI Binary
# # This single step now handles all builds
# run: >
# ${{ env.CARGO }} build --release --bin baml-cli ${{ env.TARGET_FLAGS }}
# --features static-ssl
# --no-default-features
# working-directory: engine

- name: Build CFFI Library
run: >
Expand Down
Loading