Skip to content

fix cffi build #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronvg merged 20 commits into from
Jul 2, 2025
Merged

fix cffi build #2097

Changes from 2 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
96ca571
fix cffi build
aaronvg Jul 2, 2025
285e713
version
aaronvg Jul 2, 2025
42b3a05
more try
aaronvg Jul 2, 2025
5d139ec
cffi shortcut
aaronvg Jul 2, 2025
99578d3
try
aaronvg Jul 2, 2025
c73fc5c
fuck
aaronvg Jul 2, 2025
593b73c
more thing
aaronvg Jul 2, 2025
b350333
reorg
aaronvg Jul 2, 2025
57954f0
more
aaronvg Jul 2, 2025
ce6558d
try again
aaronvg Jul 2, 2025
5472afc
try again
aaronvg Jul 2, 2025
b94c7a4
Be able to override the protoc path
aaronvg Jul 2, 2025
5621bc0
goo
aaronvg Jul 2, 2025
580829f
debug
aaronvg Jul 2, 2025
7d829bc
try with some other path things
aaronvg Jul 2, 2025
f5f88b5
try adding the cross thing
aaronvg Jul 2, 2025
0aa4dab
try fix musl
aaronvg Jul 2, 2025
d6b0df7
more fix
aaronvg Jul 2, 2025
cbc9c3b
fix more
aaronvg Jul 2, 2025
ddf54ba
release target
aaronvg Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion .github/workflows/build-cli-release.reusable.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ on:
type: boolean
default: true
required: false

push:
branches:
- protoc-fix
env:
MACOSX_DEPLOYMENT_TARGET: "10.13"

Expand Down Expand Up @@ -69,6 +71,15 @@ jobs:
# shell: bash
# run: |
# ci/ubuntu-install-packages

- uses: actions/setup-go@v5

@ellipsis-dev ellipsis-dev Bot Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate Go setup and protoc-gen-go installation steps detected. Consider consolidating these to avoid redundancy and ensure consistent Go version usage.

with:
go-version: '1.24.4'

@ellipsis-dev ellipsis-dev Bot Jul 2, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explicitly setting go-version (1.24.4) improves reproducibility. However, note that a later setup-go step uses go-version '1.21'. Ensure this discrepancy is intentional.

Suggested change
go-version: '1.24.4'
go-version: '1.21'

- name: Install protoc
run: go install github.com/golang/protobuf/protoc-gen-go@latest

- name: call protoc-gen-go
run: protoc-gen-go --version

- uses: dtolnay/rust-toolchain@stable
with:
Expand Down
Loading