Ensure all assert() calls are always compiled, do not link MPIScheduler - #32
Open
StefanFlaumberg wants to merge 2 commits into
Open
Ensure all assert() calls are always compiled, do not link MPIScheduler#32StefanFlaumberg wants to merge 2 commits into
StefanFlaumberg wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
add_compile_options(-UNDEBUG)line in the topCMakeLists.txtensures thatassert()calls are compiled in AleRax and all its submodules in all build modes, which is consistent with the current code logic. This is important in the light of the recent transition to using the Release build mode, which by default ignores theassert()calls, thus leading to numerous "unused variable" compile-time warnings and possible run-time bugs.GeneRaxCore/src/parallelization/Scheduler.cpp, and AleRax does not use it. So the linking line insrc/ale/CMakeLists.txtwas a confusing old-code leftover, now removed.This makes MPIScheduler a dependency only of GeneRax. So the cleanest solution would be moving both
Scheduler.cppand related routines to GeneRax and removing MPIScheduler from theGeneRaxCore/extdir so that it is added only to GeneRax directly via theGeneRax/extdir, thus making GeneRaxCore and AleRax completely clear of it. But this goes beyond the scope of this PR.