Regression Testing: Use Mainline & CMake by ax3l · Pull Request #2556 · BLAST-WarpX/warpx

ax3l · 2021-11-12T22:06:40Z

Mainline

use mainline repo
- requires: Fix: amr.checkpoint_files_output AMReX-Codes/regression_testing#92
remove unused tools
- unused entries tolerance = 1.e-14 and particle_tolerance -> our own checksums now (rtol in checksum.evaluate)
- set self.use_ctools = 0 (default: 1)
- expose and set self.ftools =
rebase after all fixes from run_test.sh: Own virtual env #2653 (comment) are in
modernize (can be a follow-up):
- Regression/prepare_file_ci.py
- .github/workflows/source/test_ci_matrix.sh
- this will allow to remove old GNUmake-only keys like dim =... and addToCompileString = from WarpX-tests.ini

CMake

transition to CMake
- requires: CMake: General Executable Search AMReX-Codes/regression_testing#90
- requires: CMake: Extra Configs & Superbuilds AMReX-Codes/regression_testing#91
- requires: Fix: get_recent_filename AMReX-Codes/regression_testing#99
- requires: CMake: Fix Symlinks for Exe Search AMReX-Codes/regression_testing#101
- requires: Fix runAsScript/customRunCmd: No ".ex" After Build AMReX-Codes/regression_testing#103
- requires: post-install step for Python bindings
- requires: Fix: restart test with custom run cmd AMReX-Codes/regression_testing#104
- requires: Fix: Branch Param As String AMReX-Codes/regression_testing#107
- requires: ftools: Allow to Skip 'em all AMReX-Codes/regression_testing#110 / Fix: ftools needs .split() AMReX-Codes/regression_testing#112
- nice-to-have: Improve CRASH Message: Scripts AMReX-Codes/regression_testing#102
- nice-to-have: CI: Log Build & Test Time AMReX-Codes/regression_testing#105
make sure this compiles the current checked out source and not development
make sure compile time stays about the same -> to reasonable extent, extra cmake re-configure step needed atm until we re-group runs/cache executables as in Avoid recompiling executable if already compiled in previous tests AMReX-Codes/regression_testing#69

EZoni

Thanks Axel, this looks great. I left a couple of minor comments and one question, but if you want to merge this in quickly, we can always fix typos etc. in a follow-up PR.

EZoni · 2021-12-20T19:02:05Z

+add_custom_target(install_pip
+    ${CMAKE_COMMAND} -E env PYWARPX_LIB_DIR=${CMAKE_LIBRARY_OUTPUT_DIRECTORY} python3 -m pip wheel -v --use-feature=in-tree-build ${WarpX_SOURCE_DIR}
+    COMMAND
+        python3 -m pip install --force-reinstall -v ${PYINSTALLOPTIONS} ${CMAKE_BINARY_DIR}/*whl


Just to confirm: so we don't need a --user here, correct?

That's correct. Since #2653 we run out tests (incl. GNUmake before the current PR) in a virtual environment.

--user was only needed when modifying the user-local Python environment. That was a bit unexpected/had side-effects and is solved now.

- Add `cmakeSetupOpts =` - Add `-DWarpX_DIMS`: Not an AMReX convention, so we cannot rely on `dim = ...` - Skip building unneeded tools - Add `install_pip` target: Calling `python -m pip wheel .` and install re-using the build directory. This is mainly for our CI Python regression scrips, users and package managers should just use `python -m pip wheel .` and `... install *whl` directly.

Generalize executable globber in script

* CI: mpi4py breaking setuptools API (BLAST-WarpX#2713) setuptools keeps breaking its API, which currently breaks `mpi4py` installs. Until a new mpi4py release is cut, this will serve as a work-around * Regression Testing: Use Mainline & CMake (BLAST-WarpX#2556) * Regression testing: Use mainline * Update WarpX-tests.ini - Add `cmakeSetupOpts =` - Add `-DWarpX_DIMS`: Not an AMReX convention, so we cannot rely on `dim = ...` - Skip building unneeded tools - Add `install_pip` target: Calling `python -m pip wheel .` and install re-using the build directory. This is mainly for our CI Python regression scrips, users and package managers should just use `python -m pip wheel .` and `... install *whl` directly. * LaserInjectionFromTXYEFile: General Exe Generalize executable globber in script * Docs: Update Regression Testing (CMake) * Azure: Ninja Builds (CMake) * Add x and r emitters (#131) * CI: mpi4py breaking setuptools API setuptools keeps breaking its API, which currently breaks `mpi4py` installs. Until a new mpi4py release is cut, this will serve as a work-around * added XPlaneEmitter and CI test for it * circleCI fix for mpi4py issue with new setuptools * try number 2 for fixing circleCI * try number 3 to fix circleCI * added ZCylinderEmitter and CI test for it * allow Dirichlet BCs in r when r_min != 0 with ES RZ simulations * added example file for a cylindrical vacuum TEC * allow either Dirichlet or Neumann BCs at rmax when rmin == 0 * temporary change to show that CI tests pass after changes to ES solver * added CI test of EB InfCylinderZ * changed default BC at rmax to Neumann for RZ simulations created from the setup_store * update changelog and version number plus first round of suggested changes from code review * Apply suggestions from code review Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com> * further requested review changes * change xsign and rsign to xdir and rdir * missed API change updates * Update bounds handling XPlaneEmitter Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com> * changed InfCylinderZ to CylinderZ and added optional z limits * Apply suggestions from code review Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com> Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com> Co-authored-by: Axel Huebl <axel.huebl@plasma.ninja> Co-authored-by: Peter Scherpelz <31747262+peterscherpelz@users.noreply.github.com>

Add missing CMake options in `WarpX-tests.ini`. This must have been merged in parallel to when we modernized our regression tests end of last year. BLAST-WarpX#2556

* Clean Pip Staging Directory The distutils staging (`build` -> `_tmppythonbuild`) directory that pip uses to collect build artifacts is not by default cleaned between multiple `pip` runs. This can be confusing when we recompile, because old `libwarpx*` files can be still in it that are not present in our own `build/lib/`. This cleans that staging directory before builds now. It also sets the whole `build_base` so that no artifact lands in the default, which was `build/`. So far, `bdist.linux-x86_64/` still was out-of-tree. * Python_background_mcc_1d: Add CMake Options Add missing CMake options in `WarpX-tests.ini`. This must have been merged in parallel to when we modernized our regression tests end of last year. #2556

Isolate builds locally, so we don't overwrite a developer's setup anymore. This also avoids a couple of nifty problems that can occur by mixing those envs. Originally part of BLAST-WarpX#2556

* Docs: `python3 -m pip` Use `python3 -m pip`: - works independent of PATH - always uses the right Python - is the recommended way to use `pip` * Dependencies: Python incl. venv Backported from BLAST-WarpX#2556. Follow-up to BLAST-WarpX#2653

* Regression testing: Use mainline * Update WarpX-tests.ini - Add `cmakeSetupOpts =` - Add `-DWarpX_DIMS`: Not an AMReX convention, so we cannot rely on `dim = ...` - Skip building unneeded tools - Add `install_pip` target: Calling `python -m pip wheel .` and install re-using the build directory. This is mainly for our CI Python regression scrips, users and package managers should just use `python -m pip wheel .` and `... install *whl` directly. * LaserInjectionFromTXYEFile: General Exe Generalize executable globber in script * Docs: Update Regression Testing (CMake) * Azure: Ninja Builds (CMake)

* Clean Pip Staging Directory The distutils staging (`build` -> `_tmppythonbuild`) directory that pip uses to collect build artifacts is not by default cleaned between multiple `pip` runs. This can be confusing when we recompile, because old `libwarpx*` files can be still in it that are not present in our own `build/lib/`. This cleans that staging directory before builds now. It also sets the whole `build_base` so that no artifact lands in the default, which was `build/`. So far, `bdist.linux-x86_64/` still was out-of-tree. * Python_background_mcc_1d: Add CMake Options Add missing CMake options in `WarpX-tests.ini`. This must have been merged in parallel to when we modernized our regression tests end of last year. BLAST-WarpX#2556

ax3l added the component: tests CI/CD tests label Nov 12, 2021

ax3l force-pushed the ci-regressionViaCMake branch from 0ebfee5 to a7d384e Compare November 13, 2021 23:44

ax3l commented Nov 13, 2021

View reviewed changes

Comment thread Regression/WarpX-tests.ini

ax3l force-pushed the ci-regressionViaCMake branch from a7d384e to 0344f10 Compare November 14, 2021 19:45

BLAST-WarpX deleted a comment from lgtm-com Bot Nov 15, 2021

ax3l force-pushed the ci-regressionViaCMake branch from 0344f10 to bab66a8 Compare November 15, 2021 23:24

BLAST-WarpX deleted a comment from lgtm-com Bot Nov 15, 2021

ax3l commented Nov 16, 2021

View reviewed changes

Comment thread Regression/WarpX-tests.ini Outdated

ax3l force-pushed the ci-regressionViaCMake branch 2 times, most recently from 7795da6 to b0114f0 Compare November 16, 2021 16:08

ax3l commented Nov 16, 2021

View reviewed changes

Comment thread run_test.sh

ax3l force-pushed the ci-regressionViaCMake branch 4 times, most recently from a029daa to add01b7 Compare November 18, 2021 19:51

ax3l changed the title ~~[WIP] Regression Testing: Use Mainline~~ Regression Testing: Use Mainline Nov 18, 2021

ax3l force-pushed the ci-regressionViaCMake branch 3 times, most recently from 811d2ab to 1f5a864 Compare November 21, 2021 01:25

ax3l mentioned this pull request Dec 2, 2021

Azure CI: Cache #2615

Merged

ax3l changed the title ~~Regression Testing: Use Mainline~~ [WIP] Regression Testing: Use Mainline Dec 2, 2021

ax3l force-pushed the ci-regressionViaCMake branch from 1f5a864 to b261fc5 Compare December 5, 2021 02:11

ax3l commented Dec 5, 2021

View reviewed changes

Comment thread Regression/WarpX-tests.ini

ax3l force-pushed the ci-regressionViaCMake branch 3 times, most recently from e908a72 to 98be851 Compare December 6, 2021 21:16

ax3l mentioned this pull request Dec 6, 2021

apt & conda: Update Instructions for Deps #2629

Merged

ax3l force-pushed the ci-regressionViaCMake branch from b631521 to 0a8a9fe Compare December 7, 2021 02:15

ax3l changed the title ~~[WIP] Regression Testing: Use Mainline~~ Regression Testing: Use Mainline Dec 7, 2021

ax3l mentioned this pull request Dec 20, 2021

Add 3D tests for proton boron fusion #2450

Merged

EZoni approved these changes Dec 20, 2021

View reviewed changes

ax3l force-pushed the ci-regressionViaCMake branch 2 times, most recently from 3429531 to 23aefbc Compare December 21, 2021 00:39

RemiLehe approved these changes Dec 21, 2021

View reviewed changes

RemiLehe enabled auto-merge (squash) December 21, 2021 00:40

ax3l assigned RemiLehe Dec 21, 2021

This was referenced Dec 21, 2021

CI: Reduce Runtime of Some Galilean Tests #2625

Merged

Overly long running physics tests #2630

Closed

ax3l disabled auto-merge December 21, 2021 16:52

Regression testing: Use mainline

ec913b9

ax3l force-pushed the ci-regressionViaCMake branch 2 times, most recently from c47f428 to 3a8a935 Compare December 29, 2021 10:29

ax3l added 4 commits December 29, 2021 04:33

LaserInjectionFromTXYEFile: General Exe

8bca8e5

Generalize executable globber in script

Docs: Update Regression Testing (CMake)

6fa70fd

Azure: Ninja Builds (CMake)

51c6598

ax3l force-pushed the ci-regressionViaCMake branch from 3a8a935 to 51c6598 Compare December 29, 2021 12:33

ax3l merged commit 5f8f8c8 into BLAST-WarpX:development Dec 29, 2021

ax3l deleted the ci-regressionViaCMake branch December 29, 2021 14:21

ax3l mentioned this pull request Jan 3, 2022

Add PICMI Scripts for LWFA Tests #2700

Merged

ax3l mentioned this pull request Mar 3, 2022

Python_restart_eb: Add CMake Options #2919

Merged

Navigation Menu

Uh oh!

Regression Testing: Use Mainline & CMake - #2556

Regression Testing: Use Mainline & CMake#2556
ax3l merged 5 commits into
BLAST-WarpX:developmentfrom
ax3l:ci-regressionViaCMake

ax3l commented Nov 12, 2021 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EZoni left a comment

Uh oh!

Uh oh!

EZoni Dec 20, 2021

Uh oh!

ax3l Dec 21, 2021

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ax3l commented Nov 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Mainline

CMake

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

EZoni left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

EZoni Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

ax3l Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ax3l commented Nov 12, 2021 •

edited

Loading