Skip to content

Sync .github/skills directory with azure-sdk-tools for PR 16380 - #10217

Open
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sync-.github-skills-fix/vally-skill-eval-environment-skills-16380
Open

Sync .github/skills directory with azure-sdk-tools for PR 16380#10217
azure-sdk-automation[bot] wants to merge 1 commit into
mainfrom
sync-.github-skills-fix/vally-skill-eval-environment-skills-16380

Conversation

@azure-sdk-automation

Copy link
Copy Markdown
Contributor

Sync .github/skills directory with azure-sdk-tools for PR Azure/azure-sdk-tools#16380 See eng/common workflow

@azure-sdk-automation
azure-sdk-automation Bot requested a review from a team as a code owner August 6, 2026 01:59
@azure-sdk-automation
azure-sdk-automation Bot requested review from Helen Gao (helen229) and a balanced review from Copilot August 6, 2026 01:59
@azure-sdk-automation azure-sdk-automation Bot added EngSys This issue is impacting the engineering system. Central-EngSys This issue is owned by the Engineering System team. labels Aug 6, 2026
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
1 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.

Updates skill eval definitions and skill docs to improve routing/trigger accuracy across several Azure SDK utility skills, including more explicit environments and tool-call assertions.

Changes:

  • Standardizes eval configuration blocks (e.g., defaults) and adds environment.skills entries to stimuli for more reliable skill loading/routing.
  • Expands and clarifies trigger/anti-trigger prompts (including more realistic URLs/IDs) and strengthens graders (e.g., requiring specific tool calls).
  • Updates SKILL.md trigger guidance to better capture “how-to” release-plan/release questions.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
.github/skills/azsdk-common-sdk-release/evals/trigger.eval.yaml Adds per-stimulus environment skill loading and refines prompts/graders for release vs. non-release routing.
.github/skills/azsdk-common-sdk-release/SKILL.md Expands trigger phrases and adds guidance for informational release questions.
.github/skills/azsdk-common-prepare-release-plan/evals/trigger.eval.yaml Adds per-stimulus environment and introduces a tool-call-based assertion for PR→release-plan linking.
.github/skills/azsdk-common-prepare-release-plan/SKILL.md Refines description/trigger text to match “prepare release plan” intents more closely.
.github/skills/azsdk-common-pipeline-fixer/evals/trigger.eval.yaml Adds environments and strengthens anti-trigger routing to pipeline-analysis / other skills.
.github/skills/azsdk-common-pipeline-analysis/evals/trigger.eval.yaml Adds environments and updates prompts to emphasize analyze-only behavior and clearer routing.
.github/skills/azsdk-common-generate-sdk-locally/evals/eval.yaml Adds environments and improves negative/edge prompts; strengthens routing/tool-call expectations.
.github/skills/azsdk-common-apiview-feedback-resolution/evals/trigger.eval.yaml Adds environments and improves prompts for URL-based APIView retrieval and anti-trigger routing.
.github/skills/azsdk-common-apiview-feedback-resolution/evals/eval.yaml Adds environment reuse via anchor/alias and strengthens graders to require APIView tool calls.

Comment on lines +23 to +26
environment:
&apiviewSkill # Load the real skill so the executor can route to it and call its tools.
skills:
- ..
- name: apiview-edge-001
prompt: "An APIView reviewer says I need to rename 'ComputeProvisioningState' to 'ProvisioningState' in my SDK. Use the SDK customization tools to apply this rename."
prompt: "An APIView reviewer at https://spa.apiview.dev/review/mock-dotnet-sdk?activeApiRevisionId=mock-dotnet-revision says I need to rename 'ComputeProvisioningState' to 'ProvisioningState' in the .NET SDK package sdk/compute/Azure.ResourceManager.Compute (~/repos/azure-sdk-for-net). Retrieve the feedback and use the SDK customization tools to apply this rename."
environment: *apiviewSkill
- name: apiview-no-feedback-001
prompt: "Check if there are any APIView comments on my .NET SDK PR that I need to address before release."
prompt: "Resolve APIView feedback for my .NET SDK PR. Start by checking https://spa.apiview.dev/review/mock-dotnet-sdk?activeApiRevisionId=mock-no-feedback; if there are no comments, report that clearly."
environment: *apiviewSkill
- name: apiview-negative-001
prompt: "I need to create a new TypeSpec project for my Azure Storage service."
prompt: "Author Azure TypeSpec by adding an optional color property to the WidgetSuite model in main.tsp."
environment: *apiviewSkill
- name: basic-trigger
prompt: "I have APIView comments on my SDK PR that need to be resolved. Can you help?"
prompt: "I have APIView comments at https://spa.apiview.dev/review/mock-sdk?activeApiRevisionId=mock-basic-trigger on my SDK PR that need to be resolved. Can you help?"
environment: *apiviewSkill

- name: anti-trigger
prompt: "How do I set up a new Azure Storage account?"
environment: *apiviewSkill

- name: url-trigger
prompt: "I have review comments on my SDK PR from this page: https://spa.apiview.dev/review/abc123?activeApiRevisionId=def456 — can you help me resolve them?"
environment: *apiviewSkill
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants