Skip to content

fix: fix repo relative path. directly use Repo.save_path. #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sng-asyncfunc merged 1 commit into from
Aug 12, 2026
Merged

fix: fix repo relative path. directly use Repo.save_path. #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions api/services/codemap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
from api.prompts import CODEMAP_ENRICH_PROMPT, CODEMAP_SKELETON_PROMPT
from api.rag import RAG
from api.schemas import CodeMap, CodeMapRequest
from api.repository import Repo

logger = get_logger(__name__)

Expand Down Expand Up @@ -148,24 +149,9 @@ def _format_context(documents: list) -> str:
return "\n\n" + ("-" * 10) + "\n\n".join(context_parts)


def local_repo_dir(repo_url: str, repo_type: str | None) -> str:
"""Resolve the on-disk directory of a cloned/local repository."""
from adalflow.utils import get_adalflow_default_root_path

repo_url = repo_url.strip()
if repo_url.startswith("http://") or repo_url.startswith("https://"):
parts = repo_url.rstrip("/").split("/")
if repo_type in ("github", "gitlab", "bitbucket") and len(parts) >= 5:
name = f"{parts[-2]}_{parts[-1].replace('.git', '')}"
else:
name = parts[-1].replace(".git", "")
return os.path.join(get_adalflow_default_root_path(), "repos", name)
return repo_url # already a local path


def read_repo_file(repo_url: str, repo_type: str | None, file_path: str) -> str:
"""Read a file from the cloned/local repository, guarding against traversal."""
repo_dir = os.path.realpath(local_repo_dir(repo_url, repo_type))
repo_dir = os.path.realpath(Repo(repo_url=repo_url, repo_type=repo_type).save_path)

@greptile-apps greptile-apps Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Untrimmed URLs resolve as local paths

When repo_url contains leading or trailing whitespace, Repo receives the untrimmed value and fails to recognize it as a URL, causing the file lookup to use the wrong directory and raise FileNotFoundError.

Suggested change
repo_dir = os.path.realpath(Repo(repo_url=repo_url, repo_type=repo_type).save_path)
repo_dir = os.path.realpath(
Repo(repo_url=repo_url.strip(), repo_type=repo_type).save_path
)

target = os.path.realpath(os.path.join(repo_dir, file_path))
if os.path.commonpath([repo_dir, target]) != repo_dir:
raise ValueError("Resolved path escapes the repository directory")
Expand Down
Loading