Fix/release pipeline spm pin and gates - #469
Merged
Merged
Conversation
Version rewriting was spread across rc-release.yml and promote-release.yml as inline sed calls. The two implementations drifted: rc-release guarded each rewrite and staged lib/, promote did neither, so 7.0.2 was nearly published reporting 7.0.2-rc1 from the public pluginVersion getter. Every silent version bug this cycle had the same shape -- a pattern that stopped matching while sed still exited 0. Add scripts/set-version.sh as the single writer for pubspec.yaml, the three plugin constants, the podspec and the SPM manifest, with native pins rewritten only when passed. Each rewrite asserts its pattern matched first. Both workflows now call it, and scripts/verify-version-consistency.sh reads the same surfaces back in rc-release, promote and production. This also closes the SPM gap: rc-release rewrote only the podspec's AppsFlyerFramework dependency, so a bumped ios_sdk_version left Package.swift behind and SPM and CocoaPods consumers linked different native SDKs. The AppsFlyerRPC binary target stays manual because its checksum cannot be derived from a version; the consistency check still compares its version. Two gates could not stop a release. create-github-release ran under always() without checking the publish job, so a tag and release could be created for a version that never reached pub.dev. The duplicate-tag check looked up tags before fetching them and matched origin/$VERSION, which resolves branches and never a remote tag, so it never fired. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.