Fix account picker infinite loading during Ledger import - #2496
Open
Maskln wants to merge 1 commit into
Open
Conversation
… for benign SDK states
superKalo
reviewed
Jul 30, 2026
| expect(controller.accountsLoading).toBe(false) | ||
| expect(controller.pageError).toBeTruthy() | ||
| expect(controller.page).toEqual(DEFAULT_PAGE) | ||
| }) |
Member
There was a problem hiding this comment.
I don't see the context behind this test. setPage({ page: 0 }) isn't reachable anyways - every caller in the UI already guards it (pagination, navigation, etc).
This either makes no sense, or covers a corner case that's not explained?
Meanwhile the change this PR actually exists for - the #setPageGeneration stale-request guard - has no test coverage.
So either swap this test for one that calls two setPage calls (assert the later page wins), or one where reset() interrupts an in-flight setPage and test if accountsLoading still lands on false.
Those would fail before the fix and actually protect the race, which would ultimately validate that the changes in this PR are actually fixing problem(s).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paired with: https://github.com/AmbireTech/ambire-app/pull/7408
Summary
#setPageGenerationto invalidate in-flightsetPage()requests and clearaccountsLoadingonreset()<= 0) leaving the spinner activepageSizefromsetInitParamsearlier so the UI can become ready soonernone, empty interaction)accountsLoading