Fix alluxio-fuse mount reporting success when the mount failed - #18756
Open
Stephen-Pu wants to merge 1 commit into
Open
Fix alluxio-fuse mount reporting success when the mount failed#18756Stephen-Pu wants to merge 1 commit into
Stephen-Pu wants to merge 1 commit into
Conversation
The mount success/failure was inferred solely from whether a background process was still alive after a fixed sleep, and $! referred to the wrapping subshell rather than the AlluxioFuse process. A process that was still starting up (or slow to fail) was therefore misreported as a successful mount even when the mount never happened. Capture the real AlluxioFuse pid and add wait_for_fuse_mount(), which polls up to the configured timeout and reports success only once the mount point actually appears in the mount table (via the existing fuse_mounted helper), bailing out early if the process exits first. Fixes Alluxio#15220
Contributor
|
Thank you for your pull request. |
apc999
approved these changes
Jul 2, 2026
Contributor
|
alluxio-bot, merge this please |
Contributor
|
merge failed: |
recklezzfiree666-pixel
approved these changes
Jul 14, 2026
recklezzfiree666-pixel
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
alluxio-fuse mount(integration/fuse/bin/alluxio-fuse) reporting asuccessful mount when the mount actually failed.
Previously the mount outcome was inferred from whether a background process was
still alive after a fixed
sleep, and$!referred to the wrapping subshell( nohup ... ) &rather than theAlluxioFuseprocess itself:This PR:
$!is the realAlluxioFusepid.wait_for_fuse_mount(pid, timeout)helper that polls up to theconfigured timeout and reports success only once the mount point actually
appears in the mount table (reusing the existing
fuse_mountedhelper),bailing out early if the process exits first.
The existing
-toption (mount_sleep_seconds) is reused as the poll budget,so there is no new configuration.
Fixes #15220. A process-liveness check alone cannot distinguish "mount
succeeded" from "process is still starting up / slow to fail but the mount never
happened", so an invalid mount (e.g.
alluxio-fuse mount / <path>) was reportedas
Successfully mountedeven though it failed. Verifying that the mount pointis actually present makes the success/failure report correct.
The
alluxio-fuse mountcommand now reportsFailed to mount ...(exit code 1)when the mount does not actually establish, instead of incorrectly reporting
success. No API or property-key changes.