Conversation
There was a problem hiding this comment.
Pull request overview
Migrates local cache tests from Testify to Shoulda and updates the required Go toolchain and dependencies.
Changes:
- Replaced Testify assertions with Shoulda and Musta.
- Raised the minimum Go version to 1.26 and updated CI.
- Refreshed dependencies and ignored vendored modules.
Reviewed changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/go.yml |
Tests exclusively with Go 1.26. |
.gitignore |
Ignores the vendor directory. |
go.mod |
Adds Shoulda and updates Go and dependencies. |
go.sum |
Records updated dependency checksums. |
internal/caches/local/disk_test.go |
Migrates disk tests to Shoulda. |
internal/caches/local/local_test.go |
Migrates cache tests to Shoulda and Musta. |
internal/testdata/go.mod |
Updates test-data module to Go 1.26. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.