feat: thread aforge harness binary path through node config - #66
Open
AbirAbbas wants to merge 1 commit into
Open
feat: thread aforge harness binary path through node config#66AbirAbbas wants to merge 1 commit into
AbirAbbas wants to merge 1 commit into
Conversation
PR_AF_AFORGE_BIN (default "aforge") now reaches HarnessConfig.aforge_bin so a node started with PR_AF_PROVIDER=aforge can point at a specific aforge binary. With SDKs that predate the aforge provider the extra field is ignored, so this is inert until the SDK supports it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
PR_AF_AFORGE_BIN(defaultaforge) and threads it intoHarnessConfig.aforge_bin, so a node started withPR_AF_PROVIDER=aforgecan point at a specific aforge binary. Companion to Agent-Field/agentfield#891 (which adds the aforge harness provider) and Agent-Field/aforge-v2#1 (which adds aforge's one-shot exec mode).PR_AF_PROVIDER=aforgeitself already passes through untouched — the provider field is a plain string.Changes Made
config.py:aforge_binfield onAIIntegrationConfig, sourced fromPR_AF_AFORGE_BINapp.py: passaforge_binintoHarnessConfigWith SDKs that predate the aforge provider,
HarnessConfigignores the extra field (pydanticextra="ignore"), so this is inert until the SDK supports it.Test Plan
ruff check src/ scripts/cleandocker buildgate passesPR_AF_AFORGE_BIN=/x/aforge→AIIntegrationConfig.from_env().aforge_bin == "/x/aforge"🤖 Generated with Claude Code