fix(skills): make the workspace handle reachable — sync the embedded mirror, resolve furrow from the package - #889
Closed
AbirAbbas wants to merge 2 commits into
Closed
fix(skills): make the workspace handle reachable — sync the embedded mirror, resolve furrow from the package#889AbirAbbas wants to merge 2 commits into
AbirAbbas wants to merge 2 commits into
Conversation
The workspace-handle section added in #885 landed in skills/ only, leaving the embedded copy the control plane actually serves 41 lines behind. Three skillkit tests have been failing on main since that merge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
furrow has no release channel today, so "use it only if furrow is on PATH" silently disabled the workspace handle for every caller. Point the lookup at `~/.agentfield/bin` (where provisioning puts it) and at a node's own vendored copy, and keep the silent-skip when neither exists. Provisioning itself belongs in the install path, not in this document. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
AbirAbbas
force-pushed
the
fix/furrow-client-discovery
branch
from
August 6, 2026 17:56
2b3d0f1 to
7e22170
Compare
Contributor
Author
|
Folded into #890 — same story, one PR instead of three. |
Contributor
📊 Coverage gateThresholds from
✅ Gate passedNo surface regressed past the allowed threshold and the aggregate stayed above the floor. |
Contributor
📐 Patch coverage gateThreshold: 80% on lines this PR touches vs
✅ Patch gate passedEvery surface whose lines were touched by this PR has patch coverage at or above the threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two small things, both found while e2e-testing #885 + Agent-Field/SWE-AF#130 against a live cloud deployment.
1.
mainis red. #885 added the workspace-handle section toskills/agentfield-use/SKILL.mdbut not to the embedded copy the control plane actually serves, leaving it 41 lines behind. Threeinternal/skillkittests have been failing since that merge (TestAgentfieldUseEmbeddedFallbackContractMatchesSource,TestSkillCatalogAndEmbeddedMirrorsStayAligned/agentfield-use,TestEmbeddedSkillSyncCheck). First commit runsscripts/sync-embedded-skills.shand nothing else.2. The handle was documented as unreachable. The skill said to use it "only if
furrowis on PATH (and, for anssh://handle,furrow-dial)" — but furrow has no release channel, so it is on nobody's PATH, and the instruction silently disabled the feature for every caller. The binaries are vendored inside the installed SWE-AF package (Agent-Field/SWE-AF#130), so the second commit replaces the PATH assumption with a lookup that checks PATH first and then the installed package, keeping the silent-skip fallback for the genuinely-not-installed case.Changes Made
fix(skills): regenerate the embeddedagentfield-usemirror (generated file; no hand edits).docs(skill):furrow_bin()resolver covering both install layouts (bin/for a//go-subdir install,go/bin/for a root install) and both platforms viauname; the ssh:// and dir: recipes now invoke the resolved paths.Test Plan
go test ./internal/skillkit— passes (was 3 failures onmainbefore this branch)go build ./...clean; the twogofmtfindings ininternal/skillkitare pre-existing and in files this PR does not touchswe-pro-linux-amd64out of~/.agentfield/packages/swe-planner/go/bin/using the identical pattern🤖 Generated with Claude Code