Skip to content

HKL3D viewer layout: connect toggle, dock column, remembered layout - #190

Open
pecomyint wants to merge 1 commit into
change/hkl3d-live-grid-workflowfrom
change/hkl3d-viewer-layout
Open

pecomyint wants to merge 1 commit into
change/hkl3d-live-grid-workflowfrom
change/hkl3d-viewer-layout

Conversation

@pecomyint

Copy link
Copy Markdown
Collaborator

Stacked on #189 — review/merge that one first; this diff shows only this PR's change.

Summary

  • One Connect/Disconnect toggle; compact connection row that no longer crops the channel field.
  • Docks in one scrollable right-hand column (Plot Mode, Live Grid, Stats/Image tabs).
  • Window geometry and dock layout persist via QSettings (_DOCK_STATE_VERSION).
  • Reset Camera is connected (isometric view + fit) with a tooltip.

Test plan

  • pytest tests/unit passes; ruff check src/dashpva/ clean
  • New tests in test_hkl_viewer_layout.py
  • Open at default size: nothing cropped; resize/close/reopen restores layout

🤖 Generated with Claude Code

…ction row, a scrollable dock column, remembered layout, and a working reset camera
@pecomyint
pecomyint requested a review from Osayi-ANL September 30, 2026 22:16
@pecomyint

Copy link
Copy Markdown
Collaborator Author

#172 is the general BaseWindow persistence foundation and should land first for issue #85. When this stacked PR is eventually rebased after #172/#189, please remove or adapt the HKL3D-specific QSettings geometry/dock implementation so there is one persistence owner. Keep this PR's targeted layout, connect-toggle, dock-column, and reset-camera improvements; only the duplicated persistence path needs reconciliation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants