Repository navigation
Conversation
Osayi-ANL
force-pushed
the
fix/hkl-calculation-throttle
branch
5 times, most recently
from
September 29, 2026 22:13
e59117c to
e6ca6ac
Compare
Osayi-ANL
force-pushed
the
fix/hkl-calculation-throttle
branch
from
October 9, 2026 19:45
e6ca6ac to
3028d33
Compare
…els win over generated defaults, hkl_setup no longer requests the removed motor-name fields, and a NaN motor position fails setup with a logged error instead of silently giving NaN HKL
…500 ms) instead of a fixed 100 ms
… so one failure would write the same error to the log thousands of times; with drop_repeats a repeated message is written once per repeat_window (default 60 s) change: area detector HKL messages go through its logger with drop_repeats instead of print()
Osayi-ANL
force-pushed
the
fix/hkl-calculation-throttle
branch
from
October 9, 2026 20:18
3028d33 to
3c8a636
Compare
Osayi-ANL
marked this pull request as ready for review
October 9, 2026 20:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Live HKL calculation works again. Each profile's explicit
HKL.SPECenergy and UB channels now win over the generated defaults, so SPEC and Bluesky configurations use their own PVs, andhkl_setupno longer requests the removed motor name fields that stopped geometry setup. A NaN motor position PV now fails setup with a logged error naming the PV, instead of silently turning every H, K, L value into NaN.HKL updates are throttled to
PREVIEW['HKL_UPDATE_INTERVAL_MS'](500 ms) instead of a fixed 100 ms.The HKL calculation reruns on every HKL PV change, so one failure would write the same error to the log thousands of times.
LogManagernow takesrepeat_window(keyword, default 60 s) andget_logger(..., drop_repeats=True)writes a repeated message once per window.BaseWindowviewers opt in withlog_drop_repeats; the Area Detector does, and its HKL messages go through its logger instead ofprint().Commits
Validation
pytest tests/unit(872 passed, each commit passes on its own),ruff check src/dashpva/