Repository navigation
Raise the samples' vite floor to 8.2.4 - #50
Merged
Merged
Conversation
vite 8.2.0 to 8.2.3 carry GHSA-587h-7wmj-h5pm (high) and further advisories fixed in 8.2.4. The four sample front ends that declare vite now require 8.2.4 or later, so no install can resolve an affected version. A fresh resolve of each sample audits clean for the whole tree and for what goes into the build; the lockfiles are not kept in the repository, so nothing else moves.
kirill-abblix
added a commit
that referenced
this pull request
Oct 28, 2026
* Describe the Shared Signals articles instead of naming them by their headings Every place here that pointed at one of the two Shared Signals articles named it by that article's heading, and the guide's heading had already changed: both links were calling it by a name it had stopped carrying. Nothing catches that, because the link still resolves, nothing fails, and the mismatch is visible only to someone who opens both. The text now says what each page is rather than quoting what it is called, so it stays true while the page is about the same thing. Neither entry quotes a heading any more. The wording also avoids looking like a quotation: no colon and no list of terms, which is what makes a phrase read as a title somebody got wrong. The reference list at the end of the sample's README puts its addresses in parentheses. The guide's former heading carried a colon of its own, and the list's "heading: address" shape read as two headings run together; both entries changed, because one of them alone is what makes a list look unmaintained. The sentence introducing the sample is rewritten rather than substituted: the new text is a noun phrase with an article and cannot stand where a proper name did. * Raise the samples' vite floor to 8.2.4 (#50) vite 8.2.0 to 8.2.3 carry GHSA-587h-7wmj-h5pm (high) and further advisories fixed in 8.2.4. The four sample front ends that declare vite now require 8.2.4 or later, so no install can resolve an affected version. A fresh resolve of each sample audits clean for the whole tree and for what goes into the build; the lockfiles are not kept in the repository, so nothing else moves. * Port the provider samples to Abblix OIDC Server 3.0 Each provider declares one tenant, resolves it with UseMultiTenancy, states its consent choice and implements the host services with the tenant first; the Identity sample keeps keys and clients per tenant. * Resume the Minimal API sign-in at the address the endpoint resolver gives The authorization endpoint's address comes from IOidcEndpointResolver, so a route prefix or a path base is part of it. * Report only a duplicate key as a client already registered Any other failure to write a registration is thrown instead of read as a taken client id. * Link the sign-up warning to its article and spell the samples' prose American * Serve each sample's one tenant without UseMultiTenancy() The providers route with UseRouting; the READMEs say the issuer stays as configured at any address the request arrives at. * Say the external-key sample's issuer has no path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The four sample front ends that declare vite now require 8.2.4 or later. vite 8.2.0 to 8.2.3 carry GHSA-587h-7wmj-h5pm (high) and further advisories fixed in 8.2.4.
A fresh resolve of each sample audits clean, both for the whole tree and for what goes into the build. The lockfiles are not kept in the repository, so nothing else moves.