chore(format): fail make format on clang-format version mismatch - #105
Open
AlexKlimaj wants to merge 1 commit into
Open
chore(format): fail make format on clang-format version mismatch#105AlexKlimaj wants to merge 1 commit into
AlexKlimaj wants to merge 1 commit into
Conversation
CI pins clang-format==22.1.5 in static-analysis.yml. format.sh only printed whatever was on PATH, so a local make format with another version produced whitespace commits that check_format then rejected. Require the pinned version (override: CLANG_FORMAT_SKIP_VERSION=1).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.github/workflows/static-analysis.ymlinstallsclang-format==22.1.5, butscripts/format.shonly required someclang-formaton PATH.AGENTS.mdtells every contributor (and agent) to runmake formatbefore committing, so a machine with a different version produced whitespace-only MCU diffs that CIcheck_formatthen rejected (seen as a commit/revert pair on the nFAULT stack).What
22.1.5informat.shand fail if the local binary does not match.pip install --user 'clang-format==22.1.5'(drop the distro-package suggestion; that is how the mismatch happens).CLANG_FORMAT_SKIP_VERSION=1(not for PRs).No C sources are rewritten.