Repository navigation
[slice] Fix logging - #1141
Merged
Merged
[slice] Fix logging#1141
Conversation
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, all the logs in logs explorer are displayed as "Error". The reason is that by default we set "Development: true" in the zap options. This means that the logs are output in the plaintext and since they are (by default) written to stderr, the log severity is inferred as Error. We should remove this default (since this is in production anyway), plus its going to output the logs in JSON which should enable the Logs explorer to figure out the correct severity.
Issue
Testing