Skip to content

[slice] Update go + fix ginkgo warning - #1104

Merged
pajakd merged 1 commit into
AI-Hypercomputer:slice-mainfrom
pajakd:fix_ginkgo_warning
Mar 11, 2026
Merged

[slice] Update go + fix ginkgo warning#1104
pajakd merged 1 commit into
AI-Hypercomputer:slice-mainfrom
pajakd:fix_ginkgo_warning

Conversation

@pajakd

@pajakd pajakd commented Mar 10, 2026

Copy link
Copy Markdown
Collaborator

Description

Bump go in hack/tools to 1.25 to match the one in the main directory. Plus update ginkgo to get rid of the warning

Ginkgo detected a version mismatch between the Ginkgo CLI and the version of Ginkgo imported by your packages:
  Ginkgo CLI Version:
    2.23.4
  Mismatched package versions found:
    2.27.2 used by e2e

Issue

Testing

@PBundyra

PBundyra commented Mar 11, 2026

Copy link
Copy Markdown
Collaborator

LGTM

@pajakd
pajakd merged commit 6afde56 into AI-Hypercomputer:slice-main Mar 11, 2026
15 of 17 checks passed
@pajakd
pajakd deleted the fix_ginkgo_warning branch March 11, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabesaba gabesaba Awaiting requested review from gabesaba gabesaba is a code owner
@PBundyra PBundyra Awaiting requested review from PBundyra PBundyra is a code owner
@mwysokin mwysokin Awaiting requested review from mwysokin mwysokin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pajakd @PBundyra