Repository navigation
Add A4X-MAX Dynamo Pareto-sweep recipes for DeepSeek-V4-Pro and DeepSeek-R1 NVFP4/FP8 - #289
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces DeepSeek-V4-Pro and DeepSeek-R1 Pareto-sweep recipes with NVIDIA Dynamo on GKE, adding comprehensive documentation, Dockerfile configurations, Helm values files, and SGLang serving configurations for various operating points. The review feedback highlights a critical mismatch in the secret key for HF_TOKEN across all Helm values files, potential silent build failures in the Dockerfile's symlink creation, and contradictory SGLang configurations where max-prefill-tokens exceeds max-total-tokens.
|
Hi @syangx39 @Chris113113 , could you help review this PR? Thanks! |
486eeed to
7d06218
Compare
[P1] Select a compatible default image for the DeepSeek-V4 configurationsLocation: Pareto README, lines 178–181. Option 1 recommends DeepSeek-V4 points p2–p8 use this backend, including the p3 configuration selected by the default deployment example. Following the recommended image option therefore fails during argument parsing, before model loading, with Suggested fix: select the image per model and make the documented SGLang 0.5.13 / Dynamo 1.2.0 stack, or another verified compatible release, the default for DeepSeek-V4. The 1.0.1 image should not be presented as supporting all three model families and their flags. [P2] Look up the frontend using the actual deployment nameLocation: Pareto README, line 452. The frontend lookup filters service names with The chart creates the DGD using Suggested fix: query by the actual deployment name, or pass Existing bot comments
Validation scopeThe static checks on the reviewed configuration found all 14 topology definitions consistent: |
…eek-R1
Package every operating point of the InferenceX GB300 Pareto curves for
DeepSeek-V4-Pro (MXFP4 + EAGLE MTP), DeepSeek-R1 NVFP4 and DeepSeek-R1 FP8
as deployable disaggregated Dynamo + SGLang recipes on A4X-MAX GKE:
- inference/a4xmax/disaggregated-serving/dynamo/pareto-sweep/: README with
three small architecture diagrams, per-model Pareto maps (points labelled
low latency / mid-curve / max throughput), deploy and sa-bench 8k/1k
benchmark steps, and links to every values file and serving config.
- pareto-sweep/{deepseek-v4-pro,deepseek-r1-nvfp4,deepseek-r1-fp8}/: 14 Helm
values files (one per topology, 2 to 18 nodes) with a short README per
model.
- src/frameworks/a4xmax/dynamo-configs/: 28 prefill/decode serving configs
taken flag-for-flag from the srt-slurm recipes of each point.
- src/docker/dynamo-sglang-deepseek/Dockerfile: layers a released ai-dynamo
onto a released SGLang image (DeepSeek-V4-Pro: SGLang v0.5.13 + Dynamo
1.2.0; DeepSeek-R1: SGLang v0.5.8.post1 + Dynamo 0.8.x). It links the
NIXL libraries only when present and warns when they are missing.
- Parent a4xmax disaggregated README and top-level index link the sub-recipe.
7d06218 to
257bd80
Compare
|
Thanks @syangx39, both fixed in 257bd80:
|
Package every operating point of the InferenceX GB300 Pareto curves for DeepSeek-V4-Pro (MXFP4 + EAGLE MTP), DeepSeek-R1 NVFP4 and DeepSeek-R1 FP8 as deployable disaggregated Dynamo + SGLang recipes on A4X-MAX GKE: