Repository navigation
Refresh A4X Dynamo Disaggregated Serving Recipes (DeepSeek-R1 NVFP4 8k1k 1P4D & 10P1D) - #285
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Dynamo inference deployment configuration, including container images, environment variables for NCCL/UCX, and deployment templates. The reviewer identified concerns regarding the use of runtime sed patching and pip install within startup scripts, suggesting these be integrated into the container build process to improve maintainability and reliability.
| env | grep NCCL_ | ||
| echo "--- END VERIFICATION ---" | ||
| pip install hf_transfer | ||
| pip install hf_transfer --break-system-packages || true |
There was a problem hiding this comment.
Installing hf_transfer at runtime via pip install during pod startup is risky and inefficient. It increases pod startup latency and introduces a runtime dependency on external network access (PyPI), which will fail in air-gapped or secure private GKE clusters. It is highly recommended to pre-install hf_transfer in the base container image.
There was a problem hiding this comment.
Removed: hf_transfer is already pre-installed in nvcr.io/nvidia/ai-dynamo/sglang-runtime:1.3.0-dev.1-cuda13, so runtime pip install at pod startup is not needed.
0a1a2da to
bc6dada
Compare
bc6dada to
1b9b845
Compare
1b9b845 to
8522165
Compare
|
@alisachen-google @syangx39 Ready for review — PTAL! |
Summary
Refreshes the A4X (GB200) disaggregated serving Dynamo recipe (
inference/a4x/disaggregated-serving/dynamo) to use the validatednvidia/DeepSeek-R1-0528-NVFP4-v2(ISL=8192,OSL=1024) SGLang recipes and Dynamo Platform1.4.2.Key Changes
0.9.0to1.4.2(with Grove + KAI scheduler enabled and Kubernetes service discoveryDYN_DISCOVERY_BACKEND=kubernetes,DYN_EVENT_PLANE=zmq,DYN_REQUEST_PLANE=tcp).nvcr.io/nvidia/ai-dynamo/sglang-runtime:1.3.0-dev.1-cuda13.src/frameworks/a4x/dynamo-configs/):1P4D, 20 GPUs / 5 A4X nodes, Low Latency):deepseekr1-fp4-1p4d-{prefill,decode}.yaml+values_wo_deepep.yaml(1 Prefill worker × 4 GPUs TP=4 EP=1 + 4 Decode workers × 4 GPUs TP=4 EP=1,flashinfer_trtllm).10P1D, 72 GPUs / 18 A4X nodes, High Throughput):deepseekr1-fp4-10p1d-{prefill,decode}.yaml+values_deepep.yaml(10 Prefill workers × 4 GPUs TP=4 EP=1 + 1 Decode worker × 32 GPUs TP=32 DP=32 EP=32 with DeepEPlow_latencyandflashinfer_cutedsl).deepseekr1-fp8-1p1d-*anddeepseekr1-fp8-10p8d-*configs.src/helm-charts/a4x/inference-templates/dynamo-deployment/):dynamo.frontend.envssupport intemplates/dynamo-graph-deployment.yaml, setsnodeSelector: kubernetes.io/arch: arm64andserviceAccountNameon Frontend pods, and removes redundant runtimepip install hf_transfer.