-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(v2): consolidate release-readiness correctness fixes #2502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
ccd3629
fix(openai): add reask fallback when RESPONSES_TOOLS output has no to…
Kropiunig 86af65d
fix: accumulate nested provider usage fields
mikemikimike 450fd60
fix: accumulate usage extra fields
mikemikimike f69f661
fix(usage): preserve existing fields on response
mikemikimike 545a0d3
fix(usage): preserve response field precedence
mikemikimike 57f6f02
fix(v2): keep raw Iterable typehint for PARALLEL_TOOLS
RezaRahemtola d7c784a
test(v2): cover current and future usage counters
jxnl bbddca1
test(v2): cover recursive usage initialization
jxnl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Vertex parallel parse loses ParallelBase
Medium Severity
For Vertex parallel tool modes, the v2 patch wrapper keeps the caller’s raw
Iterable[...]type and drops the handler’s preparedVertexAIParallelModel, while Vertexparse_responseonly runs parallel parsing whenresponse_modelis aParallelBaseinstance, so wrappedfrom_vertexaiparallel calls mis-parse multi-tool responses.Additional Locations (1)
instructor/v2/core/patch.py#L334-L336Reviewed by Cursor Bugbot for commit bbddca1. Configure here.