fix(anthropic): return tool_result for every tool_use on reask - #2486
Closed
Solaris-star wants to merge 1 commit into
Closed
fix(anthropic): return tool_result for every tool_use on reask#2486Solaris-star wants to merge 1 commit into
Solaris-star wants to merge 1 commit into
Conversation
Anthropic requires a tool_result for each tool_use block in the prior turn. handle_reask only kept the last tool_use id, so PARALLEL_TOOLS reasks dropped earlier results and the retry itself failed with 400. Collect all tool_use ids and emit one tool_result per id. Fixes 567-labs#2485
|
Looks correct — collecting every |
Collaborator
|
Consolidated and shipped in #2495. Closing this focused patch as superseded; thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When Anthropic returns multiple
tool_useblocks (normal forMode.PARALLEL_TOOLS) and a validation error triggers a reask,handle_reaskonly kept the lasttool_use_id. Anthropic requires atool_resultfor every priortool_use, so the retry request itself failed with:Fix
Collect all
tool_useids and emit onetool_resultper id (same error content,is_error=True).Test
Regression assertion now checks all three
tool_use_ids are present.Fixes #2485