fix(v2): retain legacy function_call in dump_message when content is empty - #2484
Closed
cognis-digital wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Consolidated and shipped in #2495. Closing this focused patch as superseded; thank you for the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dump_message(instructor/v2/core/messages.py) only appended the legacy OpenAIfunction_callwhen the assistant message had truthy content. Tool/function-call responses commonly usecontent=None, so the serialized message dropped the function call entirely.Because
dump_messagebuilds the assistant turn on the retry/reask path (OpenAI and Mistral handlers), a re-ask could omit the exact structured output that caused the validation failure, leaving the next request without the relevant assistant response.Fixes #2464.
Repro (before)
Fix
Remove the falsy-content guard so a present
function_callis always serialized. Behavior for non-empty string content and for list content (text/refusal flattening) is unchanged.Tests
Added
test_dump_message_retains_function_call_when_content_is_empty, which fails onmainand passes with this change. Existingdump_messagetests and the surrounding message/handler suites remain green. CHANGELOG updated under[Unreleased].